-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add missing targets field to de/registered targets log messages #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing targets field to de/registered targets log messages #3898
Conversation
Hi @applike-ss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/assign @zac-nixon @wweiwei-li |
@shraddhabang: GitHub didn't allow me to assign the following users: zac-nixon. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/assign @johngmyers |
/lgtm |
The amount of time it takes to merge this PR is ridiculous |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: applike-ss, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks for the patch! |
Issue
The logs of the aws-load-balancer-controller do not mention the targets upon registering/deregistering targets in their "success" message.
This makes it harder to search for actions and their success logs.
Description
Added targetsChunk to log messages.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯