Merge pull request #3898 from applike-ss/fix-add-missing-targets-to-logs

zac-nixon · web-flow · commit 4121037cffef · 2025-05-01T12:57:12.000-07:00
add missing targets field to de/registered targets log messages
diff --git a/pkg/targetgroupbinding/targets_manager.go b/pkg/targetgroupbinding/targets_manager.go
@@ -100,7 +100,8 @@ func (m *cachedTargetsManager) RegisterTargets(ctx context.Context, tgb *elbv2ap
 			return err
 		}
 		m.logger.Info("registered targets",
-			"arn", tgARN)
+			"arn", tgARN,
+			"targets", targetsChunk)
 		m.recordSuccessfulRegisterTargetsOperation(tgARN, targetsChunk)
 	}
 	return nil
@@ -126,7 +127,8 @@ func (m *cachedTargetsManager) DeregisterTargets(ctx context.Context, tgb *elbv2
 			return err
 		}
 		m.logger.Info("deRegistered targets",
-			"arn", tgARN)
+			"arn", tgARN,
+			"targets", targetsChunk)
 		m.recordSuccessfulDeregisterTargetsOperation(tgARN, targetsChunk)
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,8 @@ func (m cachedTargetsManager) RegisterTargets(ctx context.Context, tgb elbv2ap`
`100`	`100`	`return err`
`101`	`101`	`}`
`102`	`102`	`m.logger.Info("registered targets",`
`103`		`- "arn", tgARN)`
	`103`	`+ "arn", tgARN,`
	`104`	`+ "targets", targetsChunk)`
`104`	`105`	`m.recordSuccessfulRegisterTargetsOperation(tgARN, targetsChunk)`
`105`	`106`	`}`
`106`	`107`	`return nil`
`@@ -126,7 +127,8 @@ func (m cachedTargetsManager) DeregisterTargets(ctx context.Context, tgb elbv2`
`126`	`127`	`return err`
`127`	`128`	`}`
`128`	`129`	`m.logger.Info("deRegistered targets",`
`129`		`- "arn", tgARN)`
	`130`	`+ "arn", tgARN,`
	`131`	`+ "targets", targetsChunk)`
`130`	`132`	`m.recordSuccessfulDeregisterTargetsOperation(tgARN, targetsChunk)`
`131`	`133`	`}`
`132`	`134`	`return nil`