-
Notifications
You must be signed in to change notification settings - Fork 380
json: add fixed, fixable #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
json: add fixed, fixable #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'fixable' bool field to JSONIssue struct indicating if issue can be auto-fixed - Add 'fixed' bool field to JSONIssue struct indicating if issue was fixed (fixable && --fix flag) - Update all test expectation files with new fields - Maintain backwards compatibility with existing JSON consumers Resolves #2354
Add fixable and fixed fields to bundled integration test result files to match the new JSON output format.
Updates the expected fixable field values in bundled integration test result.json files to match the actual behavior of terraform rules: - terraform_unused_declarations: fixable=true - terraform_empty_list_equality: fixable=true - terraform_deprecated_interpolation: fixable=true - Other rules remain fixable=false as expected These changes ensure the bundled integration tests pass with the new fixable and fixed fields in the JSON formatter output.
Fixes Windows integration tests by restoring backslash path separators in result_windows.json files. On Windows, file paths use backslashes and the test expectations must match the actual output format.
wata727
approved these changes
Aug 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Sep 12, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [tflint](https://github.com/terraform-linters/tflint) | minor | `0.58.1` -> `0.59.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>terraform-linters/tflint (tflint)</summary> ### [`v0.59.1`](https://github.com/terraform-linters/tflint/releases/tag/v0.59.1) [Compare Source](terraform-linters/tflint@v0.59.0...v0.59.1) #### What's Changed ##### Enhancements - build(deps): Bump github.com/terraform-linters/tflint-ruleset-terraform from 0.12.0 to 0.13.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2351](terraform-linters/tflint#2351) - json: add fixed, fixable by [@​bendrucker](https://github.com/bendrucker) in [#​2355](terraform-linters/tflint#2355) ##### Bug Fixes - format(sarif): Add `tflint-errors` rules for errors by [@​wata727](https://github.com/wata727) in [#​2373](terraform-linters/tflint#2373) ##### Chores - build(deps): Bump github.com/sigstore/sigstore-go from 1.0.0 to 1.1.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2343](terraform-linters/tflint#2343) - build(deps): Bump golang.org/x/net from 0.41.0 to 0.42.0 in the go-x group across 1 directory by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2346](terraform-linters/tflint#2346) - build(deps): Bump sigstore/cosign-installer from 3.9.1 to 3.9.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2347](terraform-linters/tflint#2347) - workflow: validate issues by [@​bendrucker](https://github.com/bendrucker) in [#​2348](terraform-linters/tflint#2348) - build(deps): Bump google.golang.org/grpc from 1.73.0 to 1.74.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2349](terraform-linters/tflint#2349) - build(deps): Bump docker/login-action from 3.4.0 to 3.5.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2350](terraform-linters/tflint#2350) - build(deps): Bump mislav/bump-homebrew-formula-action from 3.4 to 3.5 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2353](terraform-linters/tflint#2353) - dependabot: allow actions writes by [@​bendrucker](https://github.com/bendrucker) in [#​2356](terraform-linters/tflint#2356) - build(deps): Bump docker/metadata-action from 5.7.0 to 5.8.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2352](terraform-linters/tflint#2352) - build(deps): Bump actions/checkout from 4.2.2 to 5.0.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2357](terraform-linters/tflint#2357) - build(deps): Bump the go-x group with 3 updates by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2358](terraform-linters/tflint#2358) - build(deps): Bump github.com/sigstore/sigstore-go from 1.1.0 to 1.1.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2359](terraform-linters/tflint#2359) - build(deps): Bump github.com/hashicorp/go-plugin from 1.6.3 to 1.7.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2360](terraform-linters/tflint#2360) - build(deps): Bump goreleaser/goreleaser-action from 6.3.0 to 6.4.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2361](terraform-linters/tflint#2361) - build(deps): Bump golang from 1.24-alpine3.21 to 1.25-alpine3.21 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2362](terraform-linters/tflint#2362) - build(deps): Bump github.com/go-viper/mapstructure/v2 from 2.3.0 to 2.4.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2363](terraform-linters/tflint#2363) - build(deps): Bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2364](terraform-linters/tflint#2364) - build(deps): Bump google.golang.org/grpc from 1.74.2 to 1.75.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2365](terraform-linters/tflint#2365) - build(deps): Bump github.com/zclconf/go-cty from 1.16.3 to 1.16.4 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2366](terraform-linters/tflint#2366) - build(deps): Bump github.com/ulikunitz/xz from 0.5.12 to 0.5.14 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2371](terraform-linters/tflint#2371) - Add support for Terraform v1.13 by [@​wata727](https://github.com/wata727) in [#​2372](terraform-linters/tflint#2372) - deps: Bump Go version to 1.25 by [@​wata727](https://github.com/wata727) in [#​2374](terraform-linters/tflint#2374) - Bump github.com/ulikunitz/xz to v0.5.15 by [@​wata727](https://github.com/wata727) in [#​2375](terraform-linters/tflint#2375) **Full Changelog**: <terraform-linters/tflint@v0.58.1...v0.59.1> ### [`v0.59.0`](terraform-linters/tflint@v0.58.1...v0.59.0) [Compare Source](terraform-linters/tflint@v0.58.1...v0.59.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OC4xIiwidXBkYXRlZEluVmVyIjoiNDEuOTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This was referenced Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the JSON formatter to include information about whether issues are fixable or have been fixed, addressing the feature request in #2354.
Changes
fixable
: Set totrue
when an issue can be automatically fixedfixed
: Set totrue
when an issue is fixable AND the--fix
flag is usedTesting
Example Output
Before
After
With
--fix
:Closes #2354