UI: A11y consolidation branch - for CI - do not merge #32458
+20,420
−6,897
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,6 +136,7 @@ const config = defineMain({ | |
| }, | ||
| features: { | ||
| developmentModeForBuild: true, | ||
| experimentalTestSyntax: true, | ||
| }, | ||
| staticDirs: [{ from: './bench/bundle-analyzer', to: '/bundle-analyzer' }], | ||
| viteFinal: async (viteConfig, { configType }) => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,18 +216,21 @@ const decorators = [ | |
| * This decorator renders the stories side-by-side, stacked or default based on the theme switcher | ||
| * in the toolbar | ||
| */ | ||
| (StoryFn, { globals, playFunction, testFunction, args, storyGlobals, parameters }) => { | ||
| let theme = globals.sb_theme; | ||
| let showPlayFnNotice = false; | ||
|
|
||
| // this makes the decorator be out of 'phase' with the actually selected theme in the toolbar | ||
| // but this is acceptable, I guess | ||
| // we need to ensure only a single rendering in chromatic | ||
| // a more 'correct' approach would be to set a specific theme global on every story that has a playFunction | ||
| if ( | ||
| (testFunction || (playFunction && args.autoplay !== false)) && | ||
| !(theme === 'light' || theme === 'dark') | ||
| ) { | ||
| theme = 'light'; | ||
| showPlayFnNotice = true; | ||
| } else if (isChromatic() && !storyGlobals.sb_theme && !playFunction && !testFunction) { | ||
| theme = 'stacked'; | ||
| } | ||
|
|
||
|
|
@@ -282,8 +285,8 @@ const decorators = [ | |
| <> | ||
| <PlayFnNotice> | ||
| <span> | ||
| Detected play/test function in Chromatic. Rendering only light theme to avoid | ||
| multiple play/test functions in the same story. | ||
| </span> | ||
| </PlayFnNotice> | ||
| <div style={{ marginBottom: 20 }} /> | ||
|
|
@@ -384,8 +387,8 @@ const parameters = { | |
| }, | ||
| backgrounds: { | ||
| options: { | ||
| light: { name: 'light', value: '#F6F9FC' }, | ||
| dark: { name: 'dark', value: '#1B1C1D' }, | ||
| blue: { name: 'blue', value: '#1b1a2c' }, | ||
| }, | ||
| grid: { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,7 @@ | |
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17", | ||
| "storybook": { | ||
| "displayName": "Accessibility", | ||
| "icon": "https://user-images.githubusercontent.com/263385/101991665-47042f80-3c7c-11eb-8f00-64b5a18f498a.png", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -181,7 +181,7 @@ export const A11YPanel: React.FC = () => { | |
| accessibility tests manually. | ||
| </p> | ||
| </div> | ||
| <Button ariaLabel={false} size="medium" onClick={handleManual}> | ||
| Run accessibility scan | ||
| </Button> | ||
| <p> | ||
|
|
@@ -208,7 +208,7 @@ export const A11YPanel: React.FC = () => { | |
| : JSON.stringify(error, null, 2)} | ||
| </p> | ||
| </div> | ||
| <Button ariaLabel={false} size="medium" onClick={handleManual}> | ||
| Rerun accessibility scan | ||
| </Button> | ||
| </> | ||
|
|
@@ -222,7 +222,7 @@ export const A11YPanel: React.FC = () => { | |
| test manually. | ||
| </p> | ||
| </div> | ||
| <Button ariaLabel={false} size="medium" onClick={handleManual}> | ||
| Run accessibility scan | ||
| </Button> | ||
| </> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicated paragraph and fix spelling (“superseded”).
Two consecutive sentences say the same thing; the second also misspells “superseded”. Drop the duplicate.
During development of Storybook [Tags](https://storybook.js.org/docs/writing-stories/tags), we created `dev-only`, `docs-only`, and `test-only` built-in tags. These tags were never documented and superseded by the currently-documented `dev`, `autodocs`, and `test` tags which provide more precise control. The outdated `x-only` tags are removed in 10.0. -During development of Storybook [Tags](https://storybook.js.org/docs/writing-stories/tags), we created `dev-only`, `docs-only`, and `test-only` built-in tags. These tags were never documented and superceded by the currently-documented `dev`, `autodocs`, and `test` tags which provide more precise control. The outdated `x-only` tags are removed in 10.0.📝 Committable suggestion
🤖 Prompt for AI Agents