Draft: Dynamic batching: Check for both max num edges and max num nodes when adding graph. #10467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speckhard
requested review from
rusty1s,
mananshah99 and
akihironitta
as code owners
speckhard
changed the title
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic batching sampler currently is fed a maximum number of edges or nodes. This maximum number is used as a check when deciding whether to add a graph to a mini-batch. This PR changes the input to the class to be a maximum number of edges and a maximum number of nodes. The idea here is that both numbers are important when dictating the size of memory that a batch will occupy.
More discussion is found here