support named imports in graphql transformer #4510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
squirly
commented
Apr 21, 2020
| "format": "prettier --write \"./packages/*/*/{src,bin,test}/**/*.{js,json,md}\"", | ||
| "link-all": "node scripts/link-all.js packages", | ||
| "unlink-all": "node scripts/unlink-all.js packages", | ||
| "check": "flow check", |
There was a problem hiding this comment.
Would usually expect checks to have an associated run script for running locally. Can remove if this is unwanted.
There was a problem hiding this comment.
I believe I use yarn flow check for this. Is there a particular need for a top-level script for this?
mischnic
reviewed
Apr 21, 2020
mischnic
reviewed
Apr 21, 2020
mischnic
reviewed
Apr 21, 2020
mischnic
reviewed
Apr 21, 2020
DeMoorJasper
approved these changes
Jun 10, 2020
wbinnssmith
reviewed
Jun 10, 2020
| "format": "prettier --write \"./packages/*/*/{src,bin,test}/**/*.{js,json,md}\"", | ||
| "link-all": "node scripts/link-all.js packages", | ||
| "unlink-all": "node scripts/unlink-all.js packages", | ||
| "check": "flow check", |
There was a problem hiding this comment.
I believe I use yarn flow check for this. Is there a particular need for a top-level script for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes #4472
Fixes #4511
💻 Examples
See integration test
🚨 Test instructions
Includes integration tests