Skip to content

fix(ux): show KB in progress bar instead of kB #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025
Merged

fix(ux): show KB in progress bar instead of kB #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b845941
chore(ux): show KB in progress bar instead of kB
qweeah Feb 17, 2025
ebc9e59
fix(ut): update unit tests
qweeah Feb 17, 2025
44eb98b
use float64 placeholder when formatting
qweeah Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/oras/internal/display/status/progress/humanize/bytes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

const base = 1024.0

var units = []string{"B", "kB", "MB", "GB", "TB"}
var units = []string{"B", "KB", "MB", "GB", "TB"}

type Bytes struct {
Size float64
Expand All @@ -46,7 +46,7 @@ func ToBytes(sizeInBytes int64) Bytes {

// String returns the string representation of Bytes.
func (b Bytes) String() string {
return fmt.Sprintf("%v %2s", b.Size, b.Unit)
return fmt.Sprintf("%g %2s", b.Size, b.Unit)
}

// RoundTo makes length of the size string to less than or equal to 4.
Expand Down
8 changes: 4 additions & 4 deletions cmd/oras/internal/display/status/progress/humanize/bytes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ func TestToBytes(t *testing.T) {
}{
{"0 bytes", args{0}, Bytes{0, "B"}},
{"1023 bytes", args{1023}, Bytes{1023, "B"}},
{"1 kB", args{1024}, Bytes{1, "kB"}},
{"1.5 kB", args{1024 + 512}, Bytes{1.5, "kB"}},
{"12.5 kB", args{1024 * 12.5}, Bytes{12.5, "kB"}},
{"512.5 kB", args{1024 * 512.5}, Bytes{513, "kB"}},
{"1 KB", args{1024}, Bytes{1, "KB"}},
{"1.5 KB", args{1024 + 512}, Bytes{1.5, "KB"}},
{"12.5 KB", args{1024 * 12.5}, Bytes{12.5, "KB"}},
{"512.5 KB", args{1024 * 512.5}, Bytes{513, "KB"}},
{"1 MB", args{1024 * 1024}, Bytes{1, "MB"}},
{"1 GB", args{1024 * 1024 * 1024}, Bytes{1, "GB"}},
{"1 TB", args{1024 * 1024 * 1024 * 1024}, Bytes{1, "TB"}},
Expand Down
Loading