Skip to content

Fix Markdown link checking action #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fix Markdown link checking action #196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d744aae
Remove empty ignorePattern field from config; this means the action s…
tpaschalis Jul 1, 2024
9343598
Fix links
tpaschalis Jul 1, 2024
515ba8a
Use ignorePatterns for Flipr link
tpaschalis Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .markdown_link_check_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
{
"ignorePatterns": [
{
}
],
"retryOn429": true,
"aliveStatusCodes": [
200,
Expand Down
4 changes: 2 additions & 2 deletions specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3144,14 +3144,14 @@ reduce the number of connections to the Server when a very large number

### Configuration Management

* [Uber Flipr](https://eng.uber.com/flipr/)
* [Uber Flipr](https://web.archive.org/web/20240223111552/https://www.uber.com/blog/flipr/)
Copy link
Member Author

@tpaschalis tpaschalis Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual link is now https://www.uber.com/blog/flipr/, but hitting the link with cURL results in 406 Not Acceptable so I opted for the web.archive.org link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that https://www.uber.com/blog/flipr exists, I'd vote to have an ignore pattern for this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done in 515ba8a

* Facebook's
[Holistic Configuration Management](https://research.facebook.com/file/877841159827226/holistic-configuration-management-at-facebook.pdf)
(push)

### Security and Certificate Management

* [mTLS in Go](https://kofo.dev/how-to-mtls-in-golang)
* [mTLS in Go](https://web.archive.org/web/20240223142649/https://kofo.dev/how-to-mtls-in-golang)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This person's website has gone offline so I replaced this with the link from the Wayback Machine.

* [ACME certificate management protocol](https://datatracker.ietf.org/doc/html/rfc8555)
* [ACME for client certificates](https://datatracker.ietf.org/doc/draft-moriarty-acme-client/)

Expand Down