-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Deprecate flowchart-level htmlLabels config option #6995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
on-behalf-of: @Mermaid-Chart <[email protected]>
🦋 Changeset detectedLatest commit: e82e464 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…date insertEdgeLabel to use new getEffectiveHtmlLabels helper on-behalf-of: @Mermaid-Chart <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6995 +/- ##
==========================================
+ Coverage 3.57% 3.59% +0.01%
==========================================
Files 473 474 +1
Lines 47139 47177 +38
Branches 730 732 +2
==========================================
+ Hits 1687 1694 +7
- Misses 45452 45483 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
on-behalf-of: @Mermaid-Chart <[email protected]>
on-behalf-of: @Mermaid-Chart <[email protected]>
📑 Summary
htmlLabels
andflowchart.htmlLabels
) with inconsistent precedence.flowchart.htmlLabels
. Root-level htmlLabels is now the single source of truth.📏 Design Decisions
getEffectiveHtmlLabels(config)
to centralize logic.flowchart.htmlLabels
logs a deprecation warning.flowchart.htmlLabels
as deprecated in the schema.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.