-
Notifications
You must be signed in to change notification settings - Fork 72
feat: SDKE-61 Extract and test callback logic. Part 3 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
denischilik
merged 11 commits into
development
from
feat/SDKE-61-extract-and-test-callback-logic-3
Aug 25, 2025
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f12a49c
- extract callback logic into beginTimedEventCompletionHandler method
denischilik 99440b1
- add test for beginTimedEventCompletionHandlerData method
denischilik b25a258
- move mocks in Mock folder
denischilik 448cce9
- rewrite SettingsProviderMock in Swift
denischilik 54ef6ed
- add MPDataPlanFilterProtocol
denischilik 78b34b6
- add test to increase test coverage
denischilik a8a63e6
- extract callback to method logEventCallback
denischilik 0b9d6ab
- cover logEventCallback with tests
denischilik 32076b2
- extract logScreen callback into logScreenCallback method
denischilik b2fbb51
- cover logScreenCallback with tests
denischilik a23dbdb
- check_script.sh can be launched without creating venv
denischilik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import XCTest | ||
| #if MPARTICLE_LOCATION_DISABLE | ||
| import mParticle_Apple_SDK_NoLocation | ||
| #else | ||
| import mParticle_Apple_SDK | ||
| #endif | ||
|
|
||
| class MPDataPlanFilterMock: NSObject, MPDataPlanFilterProtocol { | ||
| var isBlockedUserIdentityTypeCalled = false | ||
| var isBlockedUserIdentityTypeUserIdentityTypeParam: MPIdentity? | ||
| var isBlockedUserIdentityTypeReturnValue: Bool = false | ||
|
|
||
| func isBlockedUserIdentityType(_ userIdentityType: MPIdentity) -> Bool { | ||
| isBlockedUserIdentityTypeCalled = true | ||
| isBlockedUserIdentityTypeUserIdentityTypeParam = userIdentityType | ||
| return isBlockedUserIdentityTypeReturnValue | ||
| } | ||
|
|
||
| var isBlockedUserAttributeKeyCalled = false | ||
| var isBlockedUserAttributeKeyUserAttributeKeyParam: String? | ||
| var isBlockedUserAttributeKeyReturnValue: Bool = false | ||
|
|
||
| func isBlockedUserAttributeKey(_ userAttributeKey: String) -> Bool { | ||
| isBlockedUserAttributeKeyCalled = true | ||
| isBlockedUserAttributeKeyUserAttributeKeyParam = userAttributeKey | ||
| return isBlockedUserAttributeKeyReturnValue | ||
| } | ||
|
|
||
| var transformEventCalled = false | ||
| var transformEventEventParam: MPEvent? | ||
| var transformEventReturnValue: MPEvent? | ||
|
|
||
| func transformEvent(for event: MPEvent) -> MPEvent? { | ||
| transformEventCalled = true | ||
| transformEventEventParam = event | ||
| return transformEventReturnValue | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,5 @@ class MPUserDefaultsMock: MPUserDefaultsProtocol { | |
| synchronizeCalled = true | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import XCTest | ||
| #if MPARTICLE_LOCATION_DISABLE | ||
| import mParticle_Apple_SDK_NoLocation | ||
| #else | ||
| import mParticle_Apple_SDK | ||
| #endif | ||
|
|
||
| class SettingsProviderMock: NSObject, SettingsProviderProtocol { | ||
| var configSettings: NSMutableDictionary? | ||
| } |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.