fix: ensure correct version is set on binaries #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous bins report the incorrect version: (eg after downloading 0.2.0 the binary tells me it is `v0.1.2-13-gc533a0e`). I am not sure why this happens, perhaps the action cannot see the new tag? This doesn't make much sense as it is a new tag which triggers the release. idk. After messing around with another binary, I think this should save the correct thing.
Codecov ReportBase: 56.57% // Head: 56.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 56.57% 56.53% -0.04%
==========================================
Files 57 57
Lines 2768 2768
==========================================
- Hits 1566 1565 -1
Misses 1061 1061
- Partials 141 142 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yitsushi
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous bins report the incorrect version: (eg after downloading
0.2.0 the binary tells me it is
v0.1.2-13-gc533a0e).I am not sure why this happens, perhaps the action cannot see the new
tag? This doesn't make much sense as it is a new tag which triggers
the release. idk.
After messing around with another binary, I think this should save the
correct thing.
Closes #508