Skip to content

Conversation

torredil
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The release-notes tool includes a dependency report by default, which provides valuable information about dependency changes between releases. However, this report can be quite lengthy and clutters the changelog, making it difficult for users to quickly scan the main changes (features, bug fixes, etc.).

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

Tested manually, see screenshots below for generated release notes diff.

  • Without change:
WithoutChange
  • With change:
WithChange

Does this PR introduce a user-facing change?

Wrap release notes dependency subsection in dropdown

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: torredil
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2025
@torredil
Copy link
Member Author

@xmudrii Small QOL improvement PTAL 🙏

The motivation for this: we are currently using release notes tool to generate our CHANGELOG over at https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md (and it works great!) however, the dependencies subsection is overwhelming. Rather than disabling it in the report, we'd like to add a dropdown, ty!

@xmudrii
Copy link
Member

xmudrii commented Sep 26, 2025

This looks good to me, thank you @torredil! But before we merge this, I have two questions:

  • @saschagrunert -- is this something that could be integrated directly into go-modiff?
  • @katcosgrove -- is this okay from the release team side? I'm not sure if this will affect k/k, but I assume it will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants