-
Notifications
You must be signed in to change notification settings - Fork 72
Open
Labels
area/release-engIssues or PRs related to the Release Engineering subprojectIssues or PRs related to the Release Engineering subprojectkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.sig/releaseCategorizes an issue or PR as relevant to SIG Release.Categorizes an issue or PR as relevant to SIG Release.
Description
What would you like to be added:
A new command line flag for kpromo pr
should be added to make the staging repo prefix configurable.
Why is this needed:
SIG K8s-Infra is now suggesting new projects to create their staging repos at us-central1-docker.pkg.dev/k8s-staging-images/<project>
instead of the gcr.io/k8s-staging-<project>
form kpromo assumes. kubernetes/k8s.io#7703 (comment)
e.g. Running kpromo pr
for the dra-example-driver
project runs into the error:
could not find Manifest for "gcr.io/k8s-staging-dra-example-driver"
because its staging repo is at us-central1-docker.pkg.dev/k8s-staging-images/dra-example-driver
:
https://github.com/kubernetes/k8s.io/blob/e41113e88b5b85554d0c1b2ce33b878627e49813/registry.k8s.io/manifests/k8s-staging-dra-example-driver/promoter-manifest.yaml#L3
Metadata
Metadata
Assignees
Labels
area/release-engIssues or PRs related to the Release Engineering subprojectIssues or PRs related to the Release Engineering subprojectkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.sig/releaseCategorizes an issue or PR as relevant to SIG Release.Categorizes an issue or PR as relevant to SIG Release.