Skip to content

Add priority_class label for kueue_local_queue_quota_reserved_workloads_total metric #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

Add priority_class label for kueue_local_queue_quota_reserved_workloads_total metric #6897

merged 1 commit into from
Sep 26, 2025
+40 −36

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented Sep 17, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add priority_class label for kueue_local_queue_quota_reserved_workloads_total metric.

Which issue(s) this PR fixes:

Fixes #5989

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added priority_class label for kueue_local_queue_quota_reserved_workloads_total metric.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 260599c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68d6cfbb65301b0008995541

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 17, 2025
@vladikkuzn vladikkuzn changed the title metrics: add workload_priority_class to kueue_local_queue_quota_reser… Add workload_priority_class label for kueue_local_queue_quota_reserved_workloads_total metric Sep 17, 2025
@vladikkuzn
Copy link
Contributor Author

/assign
/ok-to-test
/cc @mbobrovskyi
/test all

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 17, 2025
@mbobrovskyi mbobrovskyi mentioned this pull request Sep 18, 2025
Closed
3 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025
@vladikkuzn vladikkuzn changed the title Add workload_priority_class label for kueue_local_queue_quota_reserved_workloads_total metric Add priority_class label for kueue_local_queue_quota_reserved_workloads_total metric Sep 26, 2025
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_quota_reserved_workloads_total branch 2 times, most recently from 4c4a60a to 032dcdb Compare September 26, 2025 11:45
@mbobrovskyi
Copy link
Contributor

@vladikkuzn could you please rebase?

@mbobrovskyi
Copy link
Contributor

Also please update site.

@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_quota_reserved_workloads_total branch from 032dcdb to 18d0d0f Compare September 26, 2025 15:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2025
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_quota_reserved_workloads_total branch from 18d0d0f to 38f9670 Compare September 26, 2025 15:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2025
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_quota_reserved_workloads_total branch from 38f9670 to fe2a7e7 Compare September 26, 2025 15:56
@vladikkuzn vladikkuzn marked this pull request as ready for review September 26, 2025 15:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2025
mbobrovskyi
mbobrovskyi reviewed Sep 26, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Sep 26, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Sep 26, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Sep 26, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Sep 26, 2025
View reviewed changes
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_quota_reserved_workloads_total branch from fe2a7e7 to 125c2c8 Compare September 26, 2025 16:20
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2025
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_quota_reserved_workloads_total branch from 125c2c8 to cbb546f Compare September 26, 2025 16:34
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_quota_reserved_workloads_total branch from cbb546f to 260599c Compare September 26, 2025 17:39
@vladikkuzn
Copy link
Contributor Author

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo September 26, 2025 17:40
@mimowo
Copy link
Contributor

mimowo commented Sep 26, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8754a9c65fd2fc67c8be3879e53ee006e7d655e7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit c171b52 into kubernetes-sigs:main Sep 26, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Sep 26, 2025
@mbobrovskyi mbobrovskyi deleted the kueue_local_queue_quota_reserved_workloads_total branch September 27, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabesaba gabesaba Awaiting requested review from gabesaba

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@kannon92 kannon92 Awaiting requested review from kannon92

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

@vladikkuzn vladikkuzn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.

Add priority_class label to Kueue metrics
4 participants
@vladikkuzn @k8s-ci-robot @mbobrovskyi @mimowo