Skip to content

TrainJob integration: determine the mechanism for identifying the PodSetOverride #7000

@mimowo

Description

@mimowo

What would you like to be cleaned:

Currently the integration relies on the "kueue.x-k8s.io/override-idx" annotation

Alternatives to consider:

  1. A dedicated "manager" field in the PodSpecOverrides, issue opened in Extend the PodSetOverrides structure with "manager" field kubeflow/trainer#2856
  2. Introspect the manager recorded by Kubertenes in the "ManagedFields" structure

Why is this needed:

Relying on the annotation is not ideal, because the API is hard to reason about.

A clear API field "manager" would nicely indicate. OTOH, it might be duplicating the responsibility of the ManagedFields structure, so we should also consider this as an option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions