Skip to content

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Dec 5, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for Debian 10
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for Debian 10

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2019
@Miouge1 Miouge1 force-pushed the debian10 branch 2 times, most recently from 962bfae to c9523a1 Compare December 5, 2019 10:11
@Miouge1 Miouge1 changed the title WIP: Add support for Debian 10 Add support for Debian 10 Dec 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2019
@mattymo
Copy link
Contributor

mattymo commented Dec 5, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f845fb into kubernetes-sigs:master Dec 5, 2019
@Miouge1 Miouge1 mentioned this pull request Dec 5, 2019
erulabs added a commit to kubesail/kubespray that referenced this pull request Dec 5, 2019
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add support to Ansible 2.9 (kubernetes-sigs#5361)
  Add toleration for calico-typha on master (kubernetes-sigs#5405)
  Add CI for Amazon Linux 2 (kubernetes-sigs#5410)
  Add support for Debian 10 (kubernetes-sigs#5408)
  Add OIDC to CI (kubernetes-sigs#5407)
  Fix Python code style for inventory_builder (kubernetes-sigs#5362)
  update oidc to contain quotes (kubernetes-sigs#5406)
  Add markdown CI (kubernetes-sigs#5380)
  Update to TF v0.12.12 (kubernetes-sigs#5267)
  Fix OpenSUSE support (kubernetes-sigs#5370)
  Allow customizing kubelet healthz port and bind addr (kubernetes-sigs#5403)
  force other resolvers to be secondary when using systemd-resolved (kubernetes-sigs#5391)
  Allow inventory_builder to add nodes with hostname (kubernetes-sigs#5398)
converted: true

debian-10:
filename: debian-9-openstack-amd64.qcow2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debian-9-openstack-amd64.qcow2 -> debian-10-openstack-amd64.qcow2 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixing this in #5540

LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants