-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add conditional python3-libdnf5 install for Fedora 41+ bootstrap #12537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fedora 41+ systems use dnf5 as the default package manager, which requires python3-libdnf5 for Ansible compatibility. This task conditionally installs the package when bootstrap is needed and the Fedora version exceeds 41.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PritamDutt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The committers listed above are authorized under a signed CLA. |
Welcome @PritamDutt! |
Hi @PritamDutt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you consider integrating it (block / rescue) this way? You can cherry-pick my PR #12138 commit.
xref: #12138 (comment)
Thanks @PritamDutt |
Fedora 41+ systems use dnf5 as the default package manager, which requires python3-libdnf5 for Ansible compatibility.
This PR adds a conditional task to install python3-libdnf5 during bootstrap when:
ansible_distribution_major_version > 41
This ensures compatibility with newer Fedora releases while preserving behavior for older versions. The change is scoped, non-invasive, and aligns with the existing bootstrap logic in roles/bootstrap_os/tasks/fedora.yml.
What type of PR is this?
What this PR does / why we need it:
Ensures Ansible compatibility with Fedora 41+ systems by installing python3-libdnf5, which is required for interacting with the dnf5 package manager. Without this, bootstrap tasks may fail on newer Fedora hosts.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: