-
Notifications
You must be signed in to change notification settings - Fork 6.7k
create cilium_operator_tolerations variable in group_var #12200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @felipe88alves! |
Hi @felipe88alves. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
{% if cilium_operator_tolerations is defined %} | ||
tolerations: | ||
{{ cilium_operator_tolerations | list | to_nice_yaml(indent=2) | indent(8) }} | ||
{% else %} | ||
tolerations: | ||
- operator: Exists | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should instead ditch the conditional and define in the roles default:
cilium_operator_tolerations:
- operator: Exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented the suggestion, thanks!
cilium_operator_custom_args: [] | ||
|
||
# Tolerations of the cilium operator | ||
cilium_operator_tolerations: [{operator: "Exists"}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cilium_operator_tolerations: [{operator: "Exists"}] | |
cilium_operator_tolerations: | |
- operator: "Exists" |
No need for the json form, lets stay with yaml here 👍
Please squash your commits into one, otherwise, looks fine. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felipe88alves, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- This enables ithe override of the tolerations for the cilium-operator deployment - default behaviour is to leave the toleration as is unless the var is set
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #12153
Special notes for your reviewer:
Does this PR introduce a user-facing change?: