-
Notifications
You must be signed in to change notification settings - Fork 6.7k
update containerd.options key name #12170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update containerd.options key name #12170
Conversation
|
Welcome @flpanbin! |
Hi @flpanbin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest-failed |
6808b59
to
2bce7f7
Compare
2bce7f7
to
cda21ef
Compare
@flpanbin thanks 👍 /lgtm |
Apologies for the duplicate PR. Hopefully this will merge ASAP 😃 |
/approve
Thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flpanbin, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes an issue where the
BinaryName
field in containerd's runtime configuration was incorrectly using lowercasebinaryName
. This inconsistency caused problems with GPU-Operator installation, as it resulted in duplicate configuration entries (BinaryName
andbinaryName
) in the containerd config.toml file. (NVIDIA/gpu-operator#1374 (comment))The following is the output of
containerd config default
. The default configuration uses uppercase.Which issue(s) this PR fixes:
Fixes #12167
Special notes for your reviewer:
BinaryName
.Does this PR introduce a user-facing change?: