Skip to content

Conversation

flpanbin
Copy link
Contributor

@flpanbin flpanbin commented Apr 27, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR fixes an issue where the BinaryName field in containerd's runtime configuration was incorrectly using lowercase binaryName. This inconsistency caused problems with GPU-Operator installation, as it resulted in duplicate configuration entries (BinaryName and binaryName) in the containerd config.toml file. (NVIDIA/gpu-operator#1374 (comment))

The following is the output of containerd config default . The default configuration uses uppercase.

...
    [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc.options]
      BinaryName = ""
      CriuImagePath = ""
      CriuPath = ""
      CriuWorkPath = ""
      IoGid = 0
      IoUid = 0
      NoNewKeyring = false
      NoPivotRoot = false
      Root = ""
      ShimCgroup = ""
      SystemdCgroup = false
...

Which issue(s) this PR fixes:

Fixes #12167

Special notes for your reviewer:

  • The change aligns with containerd's official configuration format where the field is defined as BinaryName.
  • This fix ensures compatibility with GPU-Operator's expectations of the containerd configuration.

Does this PR introduce a user-facing change?:

Update containerd.options key name

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 27, 2025
Copy link

linux-foundation-easycla bot commented Apr 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: flpanbin / name: bin.pan (cda21ef)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @flpanbin!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @flpanbin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 27, 2025
@VannTen
Copy link
Contributor

VannTen commented Apr 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2025
@mzaian
Copy link
Contributor

mzaian commented Apr 28, 2025

/retest-failed

@flpanbin flpanbin force-pushed the fix-containerd-config branch 2 times, most recently from 6808b59 to 2bce7f7 Compare April 29, 2025 05:59
@flpanbin flpanbin force-pushed the fix-containerd-config branch from 2bce7f7 to cda21ef Compare April 29, 2025 06:39
@ErikJiang
Copy link
Member

@flpanbin thanks 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 29, 2025
@mkjpryor
Copy link

mkjpryor commented May 2, 2025

Apologies for the duplicate PR. Hopefully this will merge ASAP 😃

@tico88612
Copy link
Member

@VannTen @mzaian Could you take a look for this? Thanks!

@VannTen
Copy link
Contributor

VannTen commented May 3, 2025 via email

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flpanbin, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6f0fc02 into kubernetes-sigs:master May 3, 2025
46 checks passed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 8, 2025
@tico88612
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerd config field binaryName error
7 participants