-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix: Enable NRI for containerd and disable plugin when nri_enabled is false #12152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @ShinyaIshitobi! |
Hi @ShinyaIshitobi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you!
/assign |
/assign VannTen |
Thanks @ShinyaIshitobi |
/retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check my understanding: this is about following upstream defaults, right ?
NRI is enabled on containerd but not on CRI-O ?
IMO even if it's upstream, it warrants a release.
Yes, this is following containerd upstream, and make sure CRI-O's NRI default is still disabled. |
Ok, thanks
/approve
/release-note-edit
```release-note
Enable NRI by default on containerd (following containerd defaults)
```
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ShinyaIshitobi, tico88612, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… false (kubernetes-sigs#12152) * fix(containerd): always render NRI plugin block with conditional disable flag * feat: enable Node Resource Interface plugin when using containerd * fix: remove the * fix: fix for linter
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR updates the
nri_enabled
configuration in Kubespray to:container_manager == 'containerd'
Which issue(s) this PR fixes:
Fixes #12118
Special notes for your reviewer:
This is my first open-source contribution, so there may be areas that need improvement; thank you in advance for your review.
Does this PR introduce a user-facing change?: