-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add iproute(2) package checking #11816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ok-to-test |
23e307b
to
e0f1912
Compare
I would rather we use the tasks in preinstall/task/0070-system-packages.yml. Problem is, we gather ips before that, so we can't. But I'm not sure it's a requirement, so we might try to move the tasks order. That said, this is harder to do than this, so I'm okay with merging this, but could you add a disclaimer (Like a TODO on each of those tasks) so we don't forget about it ? |
e0f1912
to
a58cc94
Compare
Yes, sine the task execution order, this pr is just a simple and fast way to implent iproute checking, but cause redundant codes. After it merged, we can refactor the tasks and change the tasks order |
Signed-off-by: ekko <[email protected]>
a58cc94
to
e62f1af
Compare
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0ekk, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ekko <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
From ansible doc and #11679, it is necessary to check
ip
utilities to avoid getting invaild facts.iproute:
iproute2:
Which issue(s) this PR fixes:
Fixes #11679
Special notes for your reviewer:
Does this PR introduce a user-facing change?: