Skip to content

Better to create events when failed to deploy the job by jobset #1024

@zhouying7780

Description

@zhouying7780

What would you like to be added:
Better to create events when failed to deploy the job by jobset

Why is this needed:
failed to create the worker job, but no events , check the jobset-controller-manager , could see logs :
2025-09-05T11:27:55Z ERROR Reconciler error {"controller": "jobset", "controllerGroup": "jobset.x-k8s.io", "controllerKind": "JobSet", "JobSet": {"name":"success-policy","namespace":"zhouy"}, "namespace": "zhouy", "name": "success-policy", "reconcileID": "0b09ae51-1cd2-4c31-a908-87d0bee067a8", "error": "job "success-policy-workers-0" creation failed with error: Job.batch "success-policy-workers-0" is invalid: spec.completions: Required value: when completion mode is Indexed"}sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:353sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:300sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.1 /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:202

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Untriaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions