-
Notifications
You must be signed in to change notification settings - Fork 596
BackendTLSPolicy conformance tests for observedGeneration bump #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackendTLSPolicy conformance tests for observedGeneration bump #3997
Conversation
Signed-off-by: Norwin Schnyder <[email protected]>
/cc @kl52752 |
@snorwin: GitHub didn't allow me to request PR reviews from the following users: kl52752. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
||
// BackendTLSPolicyMustHaveLatestConditions will fail the test if there are | ||
// conditions that were not updated | ||
func BackendTLSPolicyMustHaveLatestConditions(t *testing.T, r *v1alpha3.BackendTLSPolicy) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a subset of BackendTLSPolicyMustHaveCondition
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly, it doesn’t explicitly assert the observedGeneration
bump, but I agree it’s implicitly covered in the BackendTLSPolicyMustHaveCondition
since the results of ConditionsHaveLatestObservedGeneration
is used as a retry condition.
Signed-off-by: Norwin Schnyder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, LGTM :)
/lgtm |
/assign @arkodg |
Thanks @snorwin! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752, rikatz, robscott, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
Add a conformance test for BackendTLSPolicy to verify that the
observedGeneration
is correctly updated for all status conditions, similar to theGatewayClassObservedGenerationBump
orHTTPRouteObservedGenerationBump
test.Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: