Skip to content

Conversation

snorwin
Copy link
Member

@snorwin snorwin commented Aug 15, 2025

What type of PR is this?

/kind test
/area conformance-test

What this PR does / why we need it:
Add a conformance test for BackendTLSPolicy to verify that the observedGeneration is correctly updated for all status conditions, similar to the GatewayClassObservedGenerationBump or HTTPRouteObservedGenerationBump test.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2025
@snorwin
Copy link
Member Author

snorwin commented Aug 15, 2025

/cc @kl52752

@k8s-ci-robot
Copy link
Contributor

@snorwin: GitHub didn't allow me to request PR reviews from the following users: kl52752.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kl52752

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


// BackendTLSPolicyMustHaveLatestConditions will fail the test if there are
// conditions that were not updated
func BackendTLSPolicyMustHaveLatestConditions(t *testing.T, r *v1alpha3.BackendTLSPolicy) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a subset of BackendTLSPolicyMustHaveCondition?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly, it doesn’t explicitly assert the observedGeneration bump, but I agree it’s implicitly covered in the BackendTLSPolicyMustHaveCondition since the results of ConditionsHaveLatestObservedGeneration is used as a retry condition.

Signed-off-by: Norwin Schnyder <[email protected]>
@rikatz
Copy link
Member

rikatz commented Aug 18, 2025

Thanks @snorwin I would do a quick run here but lgtm from my side.

I will wait @kl52752 to take a look as well

Copy link
Contributor

@kl52752 kl52752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM :)

@rikatz
Copy link
Member

rikatz commented Aug 18, 2025

/lgtm
Thanks @snorwin, tested here against envoy-gateway, works fine. Checked the whole resource observedGeneration evolution vs the test, it reflects the expected

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@snorwin
Copy link
Member Author

snorwin commented Aug 18, 2025

/assign @arkodg

@robscott
Copy link
Member

Thanks @snorwin!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kl52752, rikatz, robscott, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 804d644 into kubernetes-sigs:main Aug 18, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants