Add to mkdocs so at least 3 conformance projects reports are uploaded #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/M
xtineskim
changed the title
mlavacca
reviewed
Jan 13, 2025
There was a problem hiding this comment.
This addition makes a lot of sense to me. Thanks, @xtineskim!
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, xtineskim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @xtineskim! /lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adding in a check so that at minimum 3 different projects are uploaded in conformance reports before hack/mkdocs-generate-conformance.py writes to md file in site-src. I noticed currently that reports for 1.2 were pulling from 1.2.2, when only Kong and traefik uploaded their reports, this check will pull from the 1.2.1 file until more are added.
Which issue(s) this PR fixes:
Fixes # none!
Does this PR introduce a user-facing change?: