v1.4.0 incompatible with GIE v1.0.0

[howardjohn]

Reproducer:

single go file:

package main

import (
        "sigs.k8s.io/gateway-api-inference-extension/client-go/applyconfiguration"
        "sigs.k8s.io/gateway-api/conformance"
)

go get sigs.k8s.io/gateway-api-inference-extension@v1.0.0
go get sigs.k8s.io/gateway-api@v1.4.0-rc.1

Fails to compile:

# sigs.k8s.io/gateway-api-inference-extension/client-go/applyconfiguration
/home/john/go/pkg/mod/sigs.k8s.io/gateway-api-inference-extension@v1.0.0/client-go/applyconfiguration/utils.go:80:56: undefined: testing.TypeConverter
/home/john/go/pkg/mod/sigs.k8s.io/gateway-api-inference-extension@v1.0.0/client-go/applyconfiguration/utils.go:81:18: undefined: testing.TypeConverter

I think this actually from the dependency on k8s/client-go v1.34. However, its impossible to use gateway-api v1.4 with client-go v1.33; if you attempt to downgrade client-go it will also downgrade gateway-api

[erikgb]

This issue comes from the bump of https://github.com/kubernetes-sigs/structured-merge-diff from v4 to v6 in K8s 1.34. Why do you want to use gateway-api with client-go < 1.34?

[howardjohn]

I do not want to use client-go <1.34. I want to use the latest version of everything -- client-go 1.34, GIE 1.0.0, and gateway v1.4.0.

Here is a oneshot reproducer:

go mod init fake
cat <<EOF > main.go
package main

import (
        "sigs.k8s.io/gateway-api-inference-extension/client-go/applyconfiguration"
        "sigs.k8s.io/gateway-api/conformance"
)
EOF
go get sigs.k8s.io/gateway-api-inference-extension@v1.0.0
go get sigs.k8s.io/gateway-api@v1.4.0-rc.1
go mod tidy
go build ./...

$ go mod graph | rg ' k8s.io/client-go'
fake k8s.io/client-go@v0.34.0
k8s.io/apiextensions-apiserver@v0.34.0 k8s.io/client-go@v0.34.0
sigs.k8s.io/controller-runtime@v0.21.0 k8s.io/client-go@v0.33.0
sigs.k8s.io/gateway-api@v1.4.0-rc.1 k8s.io/client-go@v0.34.0
sigs.k8s.io/gateway-api-inference-extension@v1.0.0 k8s.io/client-go@v0.33.4

[robscott]

@howardjohn so the solution here is to push a GIE release that includes v0.34 k8s deps? (The dep upgrade has already happened there, just without a corresponding release)

[howardjohn]

I was able to resolve this pulling GIE from main.

Note I think if we release v1.0.1 of GIE, then users will NEED to bump to v0.34. IIUC, you cannot have the mix of dependencys on 0.33 and 0.34 due to this breaking change in client-go. So users would need to bump gateway-api and GIE together which they may or may not want. For us its fine.

[aojea]

from the snippet it seems that the combo of controller-runtime/client-go is the one causing the mismatch

sigs.k8s.io/controller-runtime@v0.21.0 k8s.io/client-go@v0.33.0
sigs.k8s.io/gateway-api@v1.4.0-rc.1 k8s.io/client-go@v0.34.0

if controller-runtime is only a dependency for running conformance , we need to figure out how to organize the code to not get pulled for building prod binaries,