-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(txt-registry): add apex record delegation check #5864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: u-kai <[email protected]>
Signed-off-by: u-kai <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @u-kai. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
After opening this PR, I realized I still need to think through a few more things. |
…and documentation Signed-off-by: u-kai <[email protected]>
…prehensive tests Signed-off-by: u-kai <[email protected]>
…cords Signed-off-by: u-kai <[email protected]>
Earlier I mentioned that I still needed to think through a few more things. |
What does it do?
Adds apex record delegation checks to prevent creating apex records when the TXT registry configuration would otherwise generate ownership TXT records outside of the managed zone.
Specifically, when
--txt-prefix
includes a record type template with a trailing dot, ExternalDNS could attempt to create TXT records that do not belong to the managed zone. This change introduces a guard (apexChecker
) to block such cases.Motivation
When using certain
--txt-prefix
configurations with apex records (records at the zone root), ExternalDNS may try to create ownership TXT records outside of the intended zone.For example, with
--txt-prefix=txt-
and an apex A record for example.com, the ownership TXT record would be created as txt-example.com, which is outside the example.com zone and therefore unmanaged.This PR ensures apex records are only created when the resulting TXT record can be safely managed within the zone.
Related: documentation clarification proposed in #5863 .
More