-
Notifications
You must be signed in to change notification settings - Fork 2.8k
test(cloudflare): mock provider for cf change tests #5852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cloudflare): mock provider for cf change tests #5852
Conversation
Hi @vflaux. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
33bab51
to
83be92a
Compare
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What does it do ?
Change
TestCloudFlareProvider_newCloudFlareChange()
to use a mockProdiver instead of a real one with fake credentials.Also edit the way tests comments are generated.
Motivation
Current implementation perform a query on cloudflare api as it use a real provider & cloudflare client which is not needed for this test.
This decrease cloudflare package test up to 800ms on my machine. (2,3s->1.5s)
More