test(wrappers): fix data races in target filter and multi-source #5833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivan katliarchuk <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
ivankatliarchuk
changed the title
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
k8s-ci-robot
added
size/M
3 tasks
mloiseleur
changed the title
vflaux
reviewed
Sep 16, 2025
| } { | ||
|
|
||
| t.Run(tc.title, func(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
With the use of independent endpoints, is this needed?
| for _, tt := range tests { | ||
|
|
||
| t.Run(tt.title, func(t *testing.T) { | ||
| t.Parallel() |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
This PR addresses test flakiness caused by data races in TestTargetFilterSource, TestTargetFilterSourceEndpoints, and TestMultiSource.
Relevant issue stretchr/testify#187
Motivation
https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/post-external-dns-push-images/1965760676924231680
More