Skip to content

Conversation

elafarge
Copy link
Contributor

What does it do ?

Release a Helm chart for v0.18.0, solves: #5574

NOTE that it's my first time contributing to the external DNS project. I read the release process documentation and tried to stick with it as much as I could but may have missed something 😊

Motivation

Would love to upgrade external-dns on our infrastructure but since there are RBAC changes, a Helm chart upgrade will also be needed.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @elafarge!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @elafarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2025
@mloiseleur
Copy link
Collaborator

/assign @stevehipwell

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elafarge you've done a good job following the docs. I think we're just waiting on #5578 to be merged at which point could you please rebase and update the release date?

@ivankatliarchuk
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2025
@stevehipwell
Copy link
Contributor

@elafarge you should be good to rebase now.

@elafarge elafarge force-pushed the etienne/bump-chart-to-0.18.0 branch from 935b2c2 to 6332880 Compare July 14, 2025 12:44
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2025
@elafarge elafarge force-pushed the etienne/bump-chart-to-0.18.0 branch from 6332880 to c4f02bc Compare July 14, 2025 12:44
@elafarge
Copy link
Contributor Author

elafarge commented Jul 14, 2025

@elafarge you should be good to rebase now.

Just did so :) EDIT: forgot the date update, just force-pushed 5 minutes later to fix that

@elafarge elafarge force-pushed the etienne/bump-chart-to-0.18.0 branch from c4f02bc to 0ea925d Compare July 14, 2025 12:47
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elafarge could you please merge the ### Fixed changelog sections (heading order is in the comment above un-released) and couple you please an an entry for your change to update the versions?

@elafarge
Copy link
Contributor Author

@elafarge could you please merge the ### Fixed changelog sections (heading order is in the comment above un-released) and couple you please an an entry for your change to update the versions?

All taken care of @stevehipwell

@mloiseleur
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elafarge.

/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1956c7e into kubernetes-sigs:master Jul 15, 2025
16 checks passed
@elafarge elafarge deleted the etienne/bump-chart-to-0.18.0 branch July 15, 2025 09:54
troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
* chore: release chart for v0.18.0

* Add version change to the changelog and merge duplicated fixed entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants