Skip to content

feat(traefik)!: disable legacy listeners on traefik.containo.us API Group #5565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2025
Merged

feat(traefik)!: disable legacy listeners on traefik.containo.us API Group #5565

merged 7 commits into from
Jul 3, 2025

Conversation

mloiseleur
Copy link
Collaborator

@mloiseleur mloiseleur commented Jun 24, 2025 •
edited
Loading

What does it do ?

  1. Rename --traefik-disable-legacy to --traefik-enable-legacy
  2. Update the code and docs accordingly
  3. Fix a linter warning about type inference

Motivation

For the context:

  • Traefik Proxy v2.10 and v2.11 listen on both API Group.
  • Traefik Proxy v3+ listen only on traefik.io API Group.

The active support of Traefik Proxy v2.11 has ended since April 25, 2025 (source). So this PR follows the upstream move and now provide the expected default behavior for supported version of Traefik Proxy.

It can be a breaking change.

  • Traefik v3 users has to remove --traefik-disable-legacy flag
  • Traefik v2 users has to add --traefik-enable-legacy if they still use the legacy API Group

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I updated unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added docs source size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2025
@ivankatliarchuk
Copy link
Contributor

Not related, but created an issue on Traefik repo traefik/traefik#11853

ivankatliarchuk
ivankatliarchuk reviewed Jun 25, 2025
View reviewed changes
ivankatliarchuk
ivankatliarchuk reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@ivankatliarchuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@mloiseleur
Copy link
Collaborator Author

@kbudde @k8r-io Any comments on this PR ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2025
@kbudde
Copy link
Contributor

kbudde commented Jul 3, 2025

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kbudde: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 3, 2025
@mloiseleur
Copy link
Collaborator Author

/approve
@ivankatliarchuk ready for a final review, when you have time.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
ivankatliarchuk
ivankatliarchuk approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ivankatliarchuk,mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8cc73bd into kubernetes-sigs:master Jul 3, 2025
13 of 14 checks passed
troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
@mloiseleur @troll-os
feat(traefik)!: disable legacy listeners on traefik.containo.us API G…
b28c089 
…roup (kubernetes-sigs#5565)

* feat(traefik)!: disable legacy listeners on traefik.containo.us API Group

* update docs accordingly

* update test accordingly

* type argument is infered

* fix rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuecs szuecs Awaiting requested review from szuecs

1 more reviewer

@ivankatliarchuk ivankatliarchuk ivankatliarchuk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ivankatliarchuk ivankatliarchuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mloiseleur @ivankatliarchuk @kbudde @k8s-ci-robot