-
Notifications
You must be signed in to change notification settings - Fork 452
🌱chore: Add golangci-lint linters #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱chore: Add golangci-lint linters #1134
Conversation
Signed-off-by: dongjiang <[email protected]>
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Signed-off-by: dongjiang <[email protected]>
# Ignore test files | ||
- linters: | ||
- dupl | ||
- ginkgolinter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is ginkgolinter excluded? Too many findings? (if yes, fine for me to exclude it for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Too many findings in _test.go files.
Co-authored-by: Stefan Büringer <[email protected]>
Signed-off-by: dongjiang <[email protected]>
Thx! /lgtm |
LGTM label has been added. Git tree hash: 17160e03dccc9c403ad7290bc396d4be15e6acf7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dongjiang1989, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is the next PR for #1132
Add golangci-lint linters to controller-tools
Sync golangci-lint linters from controller-runtime
More info see: https://golangci-lint.run/usage/linters/#disabled-by-default