Fix weighted target group comparison for forward action #4350
+912
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
LBC was incorrectly handling listener rules with weighted target groups, causing unnecessary rule modifications and creations instead of efficient priority reordering.
Description
The
CompareOptionForTargetGroupTuples
function was not sorting target groups by ARN, causing equivalent configurations with different orders to be considered different. This led to:Fix:
Local Testing Verification
Using an ingress with two rules having weighted target group actions:
Before Fix:
After Fix:
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯