-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated documentation to reflect the correct order of deletion for ingress-related resources #4347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: praddy26 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @praddy26. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…gress-related resources kubernetes-sigs#4341 Signed-off-by: Pradeep Lakshmi Narasimha <[email protected]>
7921a4b
to
6af513c
Compare
Looks great! Thank you for the doc update :D |
@praddy26: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
@praddy26: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue
Fixes #4341
Description
This PR adds documentation about the correct order of deletion for AWS Load Balancer Controller resources, particularly around Ingress and IngressClass resources. The issue arises when users delete IngressClass resources before deleting the associated Ingresses, resulting in orphaned Ingress resources that cannot be cleaned up without manual intervention.
Changes made:
docs/guide/ingress/ingress_class.md
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯