-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[feat gw-api]support source ip and handle grpc filter #4335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
82921cb
to
da6e376
Compare
can you add an e2e test that makes sure the rule is correctly materialized 🙏 |
da6e376
to
118b707
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shuqz, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[feat gw-api]update how source ip is suppported [feat gw-api]add e2e test for source ip handle rebase conflicts
/lgtm |
3a152a0
to
98cc4b1
Compare
New changes are detected. LGTM label has been removed. |
Description
Checklist
README.md
, or thedocs
directory)Test case with indexes specified and not specified
BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯