Skip to content

Conversation

shraddhabang
Copy link
Collaborator

@shraddhabang shraddhabang commented Jul 22, 2025

Description

  1. Added event handlers for Rules CRD
  2. Fixed few minor typos in logs
  3. Added unit tests for all the utility functions

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 22, 2025
GetParentRefs() []gwv1.ParentReference
GetRawRoute() interface{}
GetBackendRefs() []gwv1.BackendRef
GetListenerRuleConfigs() []gwv1.LocalObjectReference
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to return the local object reference, or is it better to load the actual CRDs and then attach them to the route descriptor? The idea of this route descriptor is that it holds data needed to make a complete gateway object, so we would need to have the CRD content loaded for the model builder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep the local object reference refs here for eventhandling since we may not need to load and attach that crd to the route if its not impacting any gateway. I plan to load the actual CRDs and attach those to RouteRule when we load attached rules since its more connected to rule than routes. https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/pkg/gateway/routeutils/loader.go#L73

@shuqz
Copy link
Collaborator

shuqz commented Jul 24, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shraddhabang, shuqz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ee75e63 into kubernetes-sigs:main Jul 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants