-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[feat: gw api] Add event handling for Rules CRD #4274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat: gw api] Add event handling for Rules CRD #4274
Conversation
controllers/gateway/eventhandlers/listener_rule_configuration_events.go
Outdated
Show resolved
Hide resolved
controllers/gateway/eventhandlers/listener_rule_configuration_events.go
Outdated
Show resolved
Hide resolved
GetParentRefs() []gwv1.ParentReference | ||
GetRawRoute() interface{} | ||
GetBackendRefs() []gwv1.BackendRef | ||
GetListenerRuleConfigs() []gwv1.LocalObjectReference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to return the local object reference, or is it better to load the actual CRDs and then attach them to the route descriptor? The idea of this route descriptor is that it holds data needed to make a complete gateway object, so we would need to have the CRD content loaded for the model builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the local object reference refs here for eventhandling since we may not need to load and attach that crd to the route if its not impacting any gateway. I plan to load the actual CRDs and attach those to RouteRule
when we load attached rules since its more connected to rule than routes. https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/pkg/gateway/routeutils/loader.go#L73
0ac71ef
to
96072f3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, shuqz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯