Skip to content

fix frontend NLB security group #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

fix frontend NLB security group #4261

merged 1 commit into from
Jul 10, 2025

Conversation

wweiwei-li
Copy link
Collaborator

Issue

#4260

Description

fix bug caused due to early return

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2025
@wweiwei-li wweiwei-li mentioned this pull request Jul 10, 2025
Closed
2 tasks
@shuqz
Copy link
Collaborator

shuqz commented Jul 10, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2025
@shuqz
Copy link
Collaborator

shuqz commented Jul 10, 2025

/approved

shraddhabang
shraddhabang approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@shraddhabang shraddhabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreybutenko, shraddhabang, shuqz, wweiwei-li

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shraddhabang,wweiwei-li]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e457112 into kubernetes-sigs:main Jul 10, 2025
9 checks passed
shuqz pushed a commit to shuqz/shuqz-aws-load-balancer-controller that referenced this pull request Jul 29, 2025
@k8s-ci-robot @shuqz
Merge pull request kubernetes-sigs#4261 from wweiwei-li/fix-sg
d55398a 
fix frontend NLB security group
@shuqz shuqz mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shraddhabang shraddhabang shraddhabang approved these changes

@shuqz shuqz shuqz approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

+1 more reviewer

@andreybutenko andreybutenko andreybutenko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@shraddhabang shraddhabang

@shuqz shuqz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wweiwei-li @shuqz @k8s-ci-robot @andreybutenko @shraddhabang