Bugfix: Add ability to patch loadbalancerconfigurations to helm RBAC

[timothy-spencer]

Issue

#4247

Description

I added the ability to patch loadbalancerconfigurations to the role created by helm. This should prevent the errors in the log that you can see in #4247.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timothy-spencer
Once this PR has been reviewed and has the lgtm label, please assign shraddhabang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @timothy-spencer!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @timothy-spencer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shraddhabang]

Hey thank you for your PR. We need to update the perms for all few more resources.

- apiGroups: ["gateway.k8s.aws"]
  resources: [loadbalancerconfigurations, targetgroupconfigurations]
  verbs: [get, list, watch, patch]

- apiGroups: ["gateway.k8s.aws"]
  resources: [loadbalancerconfigurations/finalizers, targetgroupconfigurations/finalizers]
  verbs: [update, patch]

- apiGroups: ["gateway.networking.k8s.io"]
  resources: [gatewayclasses/finalizers, gateways/finalizers]
  verbs: [update, patch]

[shraddhabang]

/ok-to-test

[timothy-spencer]

Great! I haven't hit those problems yet, just this one. I'll plug in those other resources right away.

[shraddhabang]

/lgtm
/aproved

[timothy-spencer]

I noticed that you said "/aproved", not "/approved" above. I am pretty sure that you meant "approved". :-) Thanks, and have fun!