Skip to content

Conversation

zac-nixon
Copy link
Collaborator

Description

Implements the logic to find and construct a TG config. The logic is simply finding the most relevant route specification in the list of potential route configurations and merging those values together with the TG config given in the default field.

Some notes about the logic:

  • The tag and attribute merging logic is the same as the LB config tags & attributes. I have refactored the code to share the attribute & tagging logic.
  • The route matching logic tries to find the best possible match. In order matching goes (kind + namespace + name) > (kind + namespace) > (kind). The route matching logic WILL NOT allow for a match when a namespace / name is specified and it does not match the route given.

Testing:

E2E tested, including the CRD changes. Added extensive unit tests.

Will add documentation a follow up PR that describes the merging behavior.

-->

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 5, 2025
@zac-nixon
Copy link
Collaborator Author

/retest

@shraddhabang
Copy link
Collaborator

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4178d3a into kubernetes-sigs:main Jun 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants