-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs: Change AWS Cognito Domain tip to warning #4195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since it is easy for people to miss this tip in between the examples, I propose to promote this dialog box as a warning.
The committers listed above are authorized under a signed CLA. |
Welcome @ragul-engg! |
Hi @ragul-engg. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ragul-engg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the PR. /lgtm |
@shraddhabang can you mark this PR as approved, i think the label wasn't added automatically 😅 |
Issue
Since it is easy for people to miss this tip in between the examples, I propose to promote this dialog box as a warning.
Description
Updated docs to clearly indicate how to configure the AWS Cognito domain when using its annotation
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯