Skip to content

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented May 22, 2025

Issue

Tabulation is not rendered correctly in the SG page: https://kubernetes-sigs.github.io/aws-load-balancer-controller/latest/deploy/security_groups/

Description

Updating the documentation of security group with required tabulation to make mkdocs render correct the sub items.

Before (current docs):
Screenshot From 2025-05-22 00-14-27

This PR:
Screenshot From 2025-05-22 00-20-54

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Making the mkdocs happy rendering lists with enough tabulation.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio
Once this PR has been reviewed and has the lgtm label, please assign zac-nixon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2025
@shraddhabang
Copy link
Collaborator

Thanks for the PR :)
/lgtm
/approved

@shraddhabang shraddhabang merged commit 6364771 into kubernetes-sigs:main Jun 3, 2025
8 of 9 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants