Fix prefixListIDs typos

[gdlx]

Issue

#4186

Description

Fixes a case style error in the IngressClassParams CRD field prefixListIDs and mixed use of plural and singular "PrefixListsIDs" and "PrefixListIDs".

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Hi @gdlx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gdlx]

Hi @zac-nixon,
I've made a typo in #3860 you've merged 2 months ago.
It makes the CRD unusable so maybe this PR worth a bug release.

[gdlx]

I've added another typo fix on the mixed use of plural and singular "Lists" in "PrefixListsIDs".

Really sorry for the mess 😖

[zac-nixon]

Hey @gdlx sorry for missing this during the review. As we've already shipped the CRD, we can't change the name used, as that's a breaking API change. Not following what you mean the CRD is unusable

[gdlx]

Hi @zac-nixon,
I can confirm that it actually works by using PrefixListsIDs. However, I feel bad about not complying with the standard, and I'm not sure if people have been able to use it yet, since the documentation shows the expected spec.prefixListIDs.:
https://kubernetes-sigs.github.io/aws-load-balancer-controller/latest/guide/ingress/ingress_class/#specprefixlistids

Can you confirm if you prefer just fixing the doc ?
Or maybe accept both prefixListIDs and PrefixListsIDs, but I don't like this more...(requires more dirty code)

[gdlx]

I just pushed a commit reverting my previous fixes to only fix the doc.
You may just merge it if you prefer this option.

[zac-nixon]

Thanks, it's unfortunate but I think this is the correct option. This one is on me for not checking that the field conformed to Kubernetes standards.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdlx, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zac-nixon]

/lgtm
/approved

[k8s-ci-robot]

@gdlx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-load-balancer-controller-e2e-test	9bdf97c	link	true	/test pull-aws-load-balancer-controller-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gdlx]

Hi @zac-nixon,
One late but last question about this: as the CRD is still in v1beta1, should I send a PR to propertly fix the field case as I initially proposed here, to be included in a future v1 or v1beta2 CRD ?