Subnet Discovery for Gateway API #4137
Conversation
k8s-ci-robot
added
cncf-cla: yes
zac-nixon
force-pushed
the
znixon/subnet-discovery-gw
branch
2 times, most recently
from
6cd5f05 to
8189323
Compare
| } | ||
|
|
||
| for i, elbSubnet := range elbSubnets { | ||
| fmt.Println("HERE!") |
| return nil | ||
| } | ||
|
|
||
| if len(elbSubnets) != len(subnetConfig) { |
There was a problem hiding this comment.
As this is common error among all the mutators, lets check this once before starting the mutators for each config to avoid duplicate code.
There was a problem hiding this comment.
Nice catch. I did this on purpose because I wanted the mutators to be agnostic of each other. This was to future proof these mutators where we might run a subset of them in the future.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
zac-nixon
force-pushed
the
znixon/subnet-discovery-gw
branch
from
3441e11 to
d87084c
Compare
k8s-ci-robot
removed
the
lgtm
zac-nixon
force-pushed
the
znixon/subnet-discovery-gw
branch
from
d87084c to
3c6f92a
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
Description
This PR introduces subnet discovery for the Gateway API. It sets up some of the basic model builders to resolve the information needed to construct the ELB Subnets, such as the LB scheme and IP Address Type.
The goal here is to make re-usable logic for both NLB and ALB subnet creation; essentially adding, merging, and refactoring the existing subnet logic from the service and ingress packages.
https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/pkg/service/model_build_load_balancer.go#L323
https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/pkg/ingress/model_build_load_balancer.go#L200
The goal I have in mind is to prevent one big builder object like the Ingress and Service models currently have. Instead, I'd like to strive more granular pieces of the model builder.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯