Skip to content

Add targetType field to IngressClassParams #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2025
Merged

Add targetType field to IngressClassParams #4029

merged 5 commits into from
May 1, 2025

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Jan 22, 2025 •
edited
Loading

Issue

#3518

Description

Add targetType field to IngressClassParams.

  • The field is optional.
  • If the field is specified, LBC will ignore the alb.ingress.kubernetes.io/target-type annotation.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mikutas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2025
zac-nixon
zac-nixon approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@zac-nixon zac-nixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a good change. Please change move the PR out of draft state if you want it merged. :)

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@mikutas mikutas marked this pull request as ready for review March 9, 2025 06:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from zac-nixon March 9, 2025 06:06
@mikutas mikutas mentioned this pull request Mar 11, 2025
Merged
6 tasks
@mikutas
Copy link
Contributor Author

mikutas commented Mar 28, 2025

Hi, could you check this PR again? @zac-nixon

@mikutas
Copy link
Contributor Author

mikutas commented Apr 9, 2025

rebased branch

@shraddhabang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2025
shraddhabang
shraddhabang reviewed Apr 30, 2025
View reviewed changes
docs/guide/ingress/ingress_class.md
2. `spec.tags` in IngressClassParams will have the middle priority.
3. `alb.ingress.kubernetes.io/tags` annotation will have the lowest priority.

#### spec.targetType
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Can you also add an example for this in here? This helps everyone on how to use this spec param.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added example in 2d8225c

shraddhabang
shraddhabang approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@shraddhabang shraddhabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2025
@shraddhabang shraddhabang added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 30, 2025
@shraddhabang shraddhabang requested review from wweiwei-li and removed request for oliviassss April 30, 2025 22:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2025
zac-nixon
zac-nixon approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@zac-nixon zac-nixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2025
@mikutas
Copy link
Contributor Author

mikutas commented May 1, 2025 •
edited
Loading

fixed Unit test / verify with make crds after approval @shraddhabang @zac-nixon
https://github.com/kubernetes-sigs/aws-load-balancer-controller/actions/runs/14769307530/job/41466787802

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikutas, shraddhabang, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shraddhabang,zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zac-nixon
Copy link
Collaborator

Thanks for the PR!
/lgtm
/approved

@zac-nixon zac-nixon merged commit 9b158f5 into kubernetes-sigs:main May 1, 2025
8 of 9 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2025
@mikutas mikutas deleted the 3518 branch May 2, 2025 01:10
@zac-nixon zac-nixon mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zac-nixon zac-nixon zac-nixon approved these changes

@shraddhabang shraddhabang shraddhabang approved these changes

@wweiwei-li wweiwei-li Awaiting requested review from wweiwei-li

Assignees

@zac-nixon zac-nixon

@shraddhabang shraddhabang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikutas @k8s-ci-robot @shraddhabang @zac-nixon