[feat] allow multiple targetgroupbindings to reference same tg arn if using multicluster mode #4021
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
zac-nixon
force-pushed
the
znixon/mc-same-cluster
branch
from
6d1a33c to
d118858
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
added
the
needs-rebase
zac-nixon
force-pushed
the
znixon/mc-same-cluster
branch
from
d118858 to
d00b175
Compare
k8s-ci-robot
removed
the
needs-rebase
| if err := v.checkAssumeRoleConfig(tgb); err != nil { | ||
| return err | ||
| } | ||
| if err := v.checkExistingTargetGroups(tgb); err != nil { |
There was a problem hiding this comment.
checkExistingTargetGroups is being called twice, which is not need ?
There was a problem hiding this comment.
bad rebase on my part.
…multi cluster mode
zac-nixon
force-pushed
the
znixon/mc-same-cluster
branch
from
d00b175 to
92ae3dc
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if err := v.checkAssumeRoleConfig(tgb); err != nil { | ||
| return err | ||
| } | ||
| if err := v.checkExistingTargetGroups(tgb); err != nil { |
There was a problem hiding this comment.
This is a breaking change, that wasn't mentioned in release notes.
We have a cluster with two TGBs with duplicate target group. (Yes, it is wrong, but it worked with 2.10)
Previously, this was checked only on Create. So reconcile worked OK.
Now, this is checked on Update too, so both TGBs are invalid and no reconcile is done.
While I agree that the root problem is actually the duplicate TG, this is a breaking change that we didn't expect when upgrading.
Issue
n/a
Description
Users would like to utilize the same Target Group ARN for multiple TargetGroupBindings. Previously, before Multicluster support, this was not possible as the reconcile logic would be unaware of other entities registering targets into the configured Target Group. Now, using Multicluster TargetGroupBindings, the reconcile logic is able to only operate on targets in the Target Group that belong to the specified TargetGroupBinding.
We can relax the validation logic to allow users to specify duplicate Target Group ARNs if they also specify the Multicluster flag on each binding.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯