Skip to content

feat: purl in productinfo #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: purl in productinfo #4185

merged 1 commit into from
Jun 13, 2024

Conversation

mastersans
Copy link
Member

@mastersans mastersans commented Jun 13, 2024 •
edited
Loading

purl string in ProductInfo class
I think many more things could be improved with this so do let me know your thoughts with this one.

cc @terriko @anthonyharrison @inosmeet

@mastersans mastersans marked this pull request as draft June 13, 2024 14:37
@mastersans mastersans marked this pull request as ready for review June 13, 2024 15:28
terriko
terriko approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. We could probably use a test for this, but I'll file a separate issue so we don't forget.

@terriko terriko merged commit 129cce2 into intel:main Jun 13, 2024
@terriko terriko mentioned this pull request Jun 13, 2024
Closed
@mastersans mastersans deleted the purl-product branch June 14, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mastersans @terriko