Skip to content

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 25, 2025

This PR injects the dependencies of configSelector at creation time, instead of passing a reference to the xdsResolver and having the former directly access fields from the latter.

RELEASE NOTES: none

@easwars easwars added the Type: Internal Cleanup Refactors, etc label Sep 25, 2025
@easwars easwars added this to the 1.77 Release milestone Sep 25, 2025
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.18%. Comparing base (1059e84) to head (d0b22b4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8609      +/-   ##
==========================================
+ Coverage   82.05%   82.18%   +0.12%     
==========================================
  Files         415      415              
  Lines       40694    40685       -9     
==========================================
+ Hits        33390    33435      +45     
+ Misses       5916     5874      -42     
+ Partials     1388     1376      -12     
Files with missing lines Coverage Δ
internal/xds/resolver/serviceconfig.go 85.55% <100.00%> (-0.16%) ⬇️
internal/xds/resolver/xds_resolver.go 81.76% <100.00%> (-0.37%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants