Fix remaining linting errors and enable linting on CI #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with the current eslint rules.
The formatting was done with the `npx eslint . --fix`, this should make the formatting consistent across the whole codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the codebase to pass linting requirements and then adds linting to the CI workflow.
I am not sure if all the three linting jobs I added are needed, but since all passes I suggest it is better to lint everything.
The only changes in this PR, except for style changes done by
npx eslint . --fix, is the removal of three unused imports and renaming two variables that did not follow the requirement to use camelcase.