Flux intercepting date and converting to datetime

[aneurinprice]

Describe the bug

We have run into a strange behavior of Flux where when deploying a helmrelease that contains an unquoted date, it intercepts it and coverts to datetime.

from: 2024-04-01

became

from: 2024-04-01T00:00:00Z

Setting to from: '2024-04-01' fixed this issue.

Steps to reproduce

Deploy the following helmrelease from a gitrepo

---
apiVersion: v1
kind: Namespace
metadata:
  name: loki
  labels:
    istio-injection: enabled
    goldilocks.fairwinds.com/enabled: "true"
---
apiVersion: source.toolkit.fluxcd.io/v1
kind: HelmRepository
metadata:
  name: grafana
  namespace: loki
spec:
  interval: 24h
  url: https://grafana.github.io/helm-charts
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: loki
  namespace: loki
spec:
  interval: 1h
  chart:
    spec:
      chart: loki
      version: "6.36.1"
      sourceRef:
        kind: HelmRepository
        name: grafana
        namespace: loki
      interval: 12h
  values:
    monitoring:
      serviceMonitor:
        enabled: true
    lokiCanary:
      podLabels:
        app: "loki"
    loki:
      podLabels:
        app: "loki"
      commonConfig:
        replication_factor: 1
      storage:
        type: filesystem
      schemaConfig:
        configs:
          - from: '2024-04-01'
            store: tsdb
            object_store: filesystem
            schema: v13
            index:
              prefix: loki_index_
              period: 24h
      limits_config:
        retention_period: 30d
      ingester:
        chunk_encoding: snappy
      tracing:
        enabled: true
      querier:
        # Default is 4, if you have enough memory and CPU you can increase, reduce if OOMing
        max_concurrent: 2

    deploymentMode: SingleBinary
    singleBinary:
      persistence:
        size: 10Gi
      labels:
        app: loki
      replicas: 1
      resources:
        limits:
          cpu: 3
          memory: 4Gi
        requests:
          cpu: 2
          memory: 2Gi
      extraEnv:
        # Keep a little bit lower than memory limits
        - name: GOMEMLIMIT
          value: 3750MiB

    chunksCache:
      # default is 500MB, with limited memory keep this smaller
      writebackSizeLimit: 10MB

    # Enable minio for storage
    minio:
      enabled: false

    # Zero out replica counts of other deployment modes
    backend:
      replicas: 0
    read:
      replicas: 0
    write:
      replicas: 0

    ingester:
      replicas: 0
    querier:
      replicas: 0
    queryFrontend:
      replicas: 0
    queryScheduler:
      replicas: 0
    distributor:
      replicas: 0
    compactor:
      replicas: 0
    indexGateway:
      replicas: 0
    bloomCompactor:
      replicas: 0
    bloomGateway:
      replicas: 0

There are a few steps in this chain,

FluxGitrepository -> FluxGitRepository -> kustomize -> helmrelease

Expected behavior

The field from: 2024-04-01 should remain unchanged.

Screenshots and recordings

No response

OS / Distro

macOS

Flux version

N/A

Flux check

N/A

Git provider

Bitbucket

Container Registry provider

No response

Additional context

      image: ghcr.io/fluxcd/helm-controller:v1.0.1
      image: ghcr.io/fluxcd/image-automation-controller:v0.38.0
      image: ghcr.io/fluxcd/image-reflector-controller:v0.32.0
      image: ghcr.io/fluxcd/kustomize-controller:v1.3.0
      image: ghcr.io/fluxcd/notification-controller:v1.3.0
      image: ghcr.io/fluxcd/source-controller:v1.3.0

Code of Conduct

• I agree to follow this project's Code of Conduct

[aneurinprice]

I would assume this would be happening upon conversion to json?