checkbox on the redirector page correctly reflects the current sync s… #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting state I've made the necessary changes to ensure that the checkbox on the redirector page correctly reflects the current sync setting state. Here's what I've done: First, I improved the toggleSyncSetting() function in redirectorpage.js to use the actual checkbox state when enabling or disabling sync, rather than always toggling the current setting. Next, I enhanced the page load process in redirectorpage.js to fetch the sync state directly from the background page using a new message type get-sync-state. This ensures that the checkbox always reflects the true state of the sync setting when the page loads. Finally, I added a message handler for the new get-sync-state message type in background.js to respond with the current sync state, making the system work properly. This implementation now: Correctly sets the checkbox state on page load based on the current sync setting Uses the checkbox state to properly enable or disable sync when the checkbox is clicked Ensures the checkbox state always reflects the actual sync setting, even after errors occur Signed-off-by: Tiger Kaovilai <[email protected]>
|
Idk. I guess it doesn't hurt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etting state
I've made the necessary changes to ensure that the checkbox on the redirector page correctly reflects the current sync setting state. Here's what I've done:
First, I improved the toggleSyncSetting() function in redirectorpage.js to use the actual checkbox state when enabling or disabling sync, rather than always toggling the current setting.
Next, I enhanced the page load process in redirectorpage.js to fetch the sync state directly from the background page using a new message type get-sync-state. This ensures that the checkbox always reflects the true state of the sync setting when the page loads.
Finally, I added a message handler for the new get-sync-state message type in background.js to respond with the current sync state, making the system work properly.
This implementation now:
Correctly sets the checkbox state on page load based on the current sync setting Uses the checkbox state to properly enable or disable sync when the checkbox is clicked Ensures the checkbox state always reflects the actual sync setting, even after errors occur