[wasm][interp] Add PackedSimd aliases for AddSaturate and SubtractSaturate #118089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewing
requested review from
BrzVlad,
kotlarmilos,
steveisok and
vitek-karas
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds PackedSimd aliases for the AddSaturate and SubtractSaturate methods to fix regressions introduced in a previous commit. The changes ensure these saturated arithmetic operations are properly supported in the WASM SIMD interpreter.
Key Changes
- Added
AddSaturateandSubtractSaturateto the PackedSimd alias methods list - Included these methods in the SIMD method switch case handling
- Added method definitions for both operations in the SIMD methods definition file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/mono/mini/interp/transform-simd.c | Adds AddSaturate and SubtractSaturate to alias methods array and switch case handling |
| src/mono/mono/mini/interp/simd-methods.def | Defines AddSaturate and SubtractSaturate SIMD methods |
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
lewing
changed the title
BrzVlad
approved these changes
Jul 27, 2025
|
Got the bulk of the regression back but not all of it https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu%2022.04_CompilationMode=wasm_RunKind=micro/ViperUbuntu/System.Perf_Convert.FromHexString.html |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some regressions introduced in 0b64041